Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: localized product attributes #107

Merged
merged 1 commit into from
Feb 11, 2020

Conversation

Sebastian-Haehnlein
Copy link
Contributor

@Sebastian-Haehnlein Sebastian-Haehnlein commented Feb 7, 2020

PR Type

[x] Feature

What Is the Current Behavior?

Issue Number:
Closes #91

While localized calls to the /products/<sku> REST resource return the product attribute values as localized values the attribute names are still returned in English. This will then result in a language mix in localized storefronts.

What Is the New Behavior?

The attribute values as well as the attribute names should be returned in the requested locale with the /products/<sku> call.

Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

@Sebastian-Haehnlein Sebastian-Haehnlein self-assigned this Feb 7, 2020
@Sebastian-Haehnlein Sebastian-Haehnlein added the feature New feature or request label Feb 7, 2020
@Sebastian-Haehnlein Sebastian-Haehnlein added this to the 0.18 milestone Feb 7, 2020
@Sebastian-Haehnlein Sebastian-Haehnlein force-pushed the feature/localized-product-attributes branch from 147e564 to 5ff3d94 Compare February 7, 2020 13:59
Copy link
Collaborator

@shauke shauke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A test for the changed functionality in the mapper should be added.

@Sebastian-Haehnlein Sebastian-Haehnlein force-pushed the feature/localized-product-attributes branch from 5ff3d94 to ccda0b6 Compare February 11, 2020 08:21
@shauke shauke merged commit 3205ba5 into develop Feb 11, 2020
@shauke shauke deleted the feature/localized-product-attributes branch February 11, 2020 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translation of product attribute names doesn’t work
2 participants